Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return 0 from docker init script #6104

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Always return 0 from docker init script #6104

merged 1 commit into from
Nov 8, 2024

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Nov 6, 2024

Avalon-dev has been having a timing issue where both the avalon and worker containers try to run db:migrate at the same time leading to concurrent db migrate errors. When these errors occur the container stops running. I believe returning a 0 exit code from this script will allow startup to proceed and any db:migrate errors will still be logged. This isn't an issue in other environments because db:migrate isn't run automatically as part of container startup.

Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if you are satisfied with it.

Should we be concerned about the db:migrates erroring and not finishing the migrations or is that not an issue?

@cjcolvar
Copy link
Member Author

cjcolvar commented Nov 8, 2024

Good point. That might happen but since this only affects the development environment I think the risk of that happening is less than how often the timing issue seems to be occurring so is acceptable. If it does prove to be a problem we can try another solution.

@cjcolvar cjcolvar merged commit b3411c8 into develop Nov 8, 2024
2 checks passed
@cjcolvar cjcolvar deleted the init_ok branch November 8, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants