Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify udiv #37

Merged
merged 5 commits into from
Jan 17, 2023
Merged

Verify udiv #37

merged 5 commits into from
Jan 17, 2023

Conversation

mpardesh
Copy link
Collaborator

Verify udiv. Currently:

avanhatt
avanhatt approved these changes Jan 17, 2023
View reviewed changes
Copy link
Owner

@avanhatt avanhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Interesting that bv64 is fast!

cranelift/isle/veri/veri_engine/tests/veri.rs
#[test]
fn test_udiv() {
test_from_file("./examples/udiv/udiv.isle",
// for ease of commenting out until we debug further
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mpardesh mpardesh merged commit d9c9245 into verify-main Jan 17, 2023
avanhatt pushed a commit to wellesley-prog-sys/wasmtime that referenced this pull request Sep 22, 2024
@mmcloughlin
isaspec: use substitution instead of equality constriants (avanhatt#67)
61df81b 
When generating specs from ASLp, we have to define a mapping between
spec inputs and variables in the derived constraints. Previously we
would do this lazily by introducing equality constraints. This not only
looks awful avanhatt#62, but anecdotally may also have solver performance
implications. This PR updates the spec generation to substitute the
mapped expressions for the variables instead.

Updates avanhatt#62 avanhatt#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avanhatt avanhatt avanhatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpardesh @avanhatt