Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making metadata fields optional #50

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

pritamps
Copy link
Contributor

@pritamps pritamps commented Jun 2, 2022

Fixes #49

Summary

All metadata fields should be optional since these will be org-specific or domain-specific

Tested by running locally and creating quiz

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #50 (45063f0) into main (30e7854) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          14       14           
  Lines         429      429           
=======================================
  Hits          421      421           
  Misses          8        8           
Impacted Files Coverage Δ
app/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e7854...45063f0. Read the comment docs.

@pritamps pritamps requested review from dalmia and deepansh96 June 2, 2022 08:37
@pritamps pritamps temporarily deployed to Staging June 2, 2022 09:03 Inactive
@deepansh96 deepansh96 merged commit 66acef0 into main Jun 9, 2022
@deepansh96 deepansh96 deleted the making_metadata_fields_optional branch June 9, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make metadata fields optional except for quiz type
2 participants