Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns quiz_id in response of create_quiz POST request #56

Merged
merged 4 commits into from
Jun 17, 2022

Conversation

suryabulusu
Copy link
Collaborator

Fixes #55

Summary

  • Motivation: Returns only the quiz_id instead of the entire created quiz. This reduces load on network.
  • Created quiz can be retrieved by sending a GET request at /quiz/{quiz_id} endpoint
  • Changes are also made in corresponding app/tests files

@suryabulusu suryabulusu temporarily deployed to Staging June 16, 2022 19:29 Inactive
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #56 (4de30d0) into main (e26415c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   95.98%   96.04%   +0.06%     
==========================================
  Files          16       16              
  Lines         473      481       +8     
==========================================
+ Hits          454      462       +8     
  Misses         19       19              
Impacted Files Coverage Δ
app/models.py 100.00% <100.00%> (ø)
app/routers/quizzes.py 100.00% <100.00%> (ø)
app/tests/base.py 100.00% <100.00%> (ø)
app/tests/test_quizzes.py 100.00% <100.00%> (ø)
app/tests/test_sessions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26415c...4de30d0. Read the comment docs.

Copy link
Contributor

@pritamps pritamps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I will let @deepansh96 approve. I'm only starting to get familiar with quiz ka code

@suryabulusu suryabulusu temporarily deployed to Staging June 17, 2022 05:56 Inactive
@suryabulusu suryabulusu temporarily deployed to Staging June 17, 2022 06:45 Inactive
@suryabulusu suryabulusu temporarily deployed to Staging June 17, 2022 07:21 Inactive
@suryabulusu suryabulusu merged commit 8d8d235 into main Jun 17, 2022
@suryabulusu suryabulusu deleted the return_quizId_in_createQuiz branch June 17, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_quiz POST request returns entire quiz
4 participants