Update all session answers at once #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 95.35% 94.63% -0.72%
==========================================
Files 18 18
Lines 882 914 +32
==========================================
+ Hits 841 865 +24
- Misses 41 49 +8
☔ View full report in Codecov by Sentry. |
deepansh96
requested changes
Jul 26, 2023
| # get user_id and quiz_id for logging | ||
| # Note: every session must have these keys | ||
| user_id, quiz_id = session["user_id"], session["quiz_id"] | ||
| log_message += f"(user: {user_id}, quiz: {quiz_id})" |
There was a problem hiding this comment.
more descriptive? as this message will be logged as a separate line, would be helpful for us only to keep it more verbose. For example -- Updating all session answers for the session {session_id} with {user_id} and {quiz_id}
There was a problem hiding this comment.
yes ... its a += . log_message variable already has session_id thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a patch request with only
session_idis provided tosession_answersroute, assert that json body contains all session answers, and update all session answers at once in db.This helps in syncing all session answers from frontend before test ends (especially for OMR format in low network areas).
One test added in
test_session_answers.pySolves #99
Related ADR: https://www.notion.so/avantifellows/ADR-Wait-for-Session-Answer-Response-ce48a939beb240a5b56f5c6035c53931