Eval placeholder args in show update method (from missionpinball#1702)

avanwinkle · Feb 22, 2024 · 10aaefc · 10aaefc
1 parent e38d079
commit 10aaefc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/mpf/assets/show.py b/mpf/assets/show.py
@@ -604,7 +604,7 @@ def update(self, **kwargs):
         Updates the values of a show while it runs. Currently supports only speed
         and manual_advance properties.
         """
-        updated_values = {k: v for k, v in kwargs.items() if v is not None and v != getattr(self.show_config, k)}
+        updated_values = {k: v for k, v in kwargs.items() if v is not None}
         if updated_values:
             self.show_config = self.show_config._replace(**updated_values)
 

diff --git a/mpf/config_players/show_player.py b/mpf/config_players/show_player.py
@@ -197,10 +197,9 @@ def _update(key, instance_dict, show, show_settings, queue, start_time, placehol
         del show
         del queue
         del start_time
-        del placeholder_args
         if key in instance_dict:
             instance_dict[key].update(
-                speed=show_settings.get('speed'),
+                speed=show_settings['speed'].evaluate(placeholder_args),
                 manual_advance=show_settings.get('manual_advance')
             )