Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login page jquery version is incorrect #190

Closed
pabloveintimilla opened this issue Oct 15, 2017 · 3 comments
Closed

Login page jquery version is incorrect #190

pabloveintimilla opened this issue Oct 15, 2017 · 3 comments
Assignees

Comments

@pabloveintimilla
Copy link
Contributor

When you update jquery (ex to 2.2.3), the link breaks.

<script src="{{ asset('theme/plugins/jQuery/jQuery-2.2.0.min.js') }}"></script>

@shakaran shakaran added the bug label Oct 15, 2017
@shakaran
Copy link
Collaborator

@pabloveintimilla could you specify more which kind of error receive? which error shows In javascript console?
Also it seems that you don't fill the Symfony version and AdminThemeBundle, could you specify in which version are you using?

@pabloveintimilla
Copy link
Contributor Author

@shakaran the error is 404 file not found. Because jquery version after update is 2.2.3. The url of jquery should be dynamic. My symfony version is 3.3 and the AdminThemeBundle is the current master-dev.

@shakaran
Copy link
Collaborator

I understand now. I push a fix for this in master. Unfortunally, the jquery version cames prefixed from upstream AdminLTE, so if you don't mind, you could open a issue in almasaeed2010/AdminLTE requesting that change. AdminThemeBundle is picking that file from vendor/almasaeed2010/adminlte/plugins/jQuery/jQuery-2.2.0.min.js, so you should request that they modify to vendor/almasaeed2010/adminlte/plugins/jQuery/jQuery.min.js or provide the two ways (one linked to the version and unversioned). Closing this issue since is fixed now in master. Thanks for your reporting and make better this bundle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants