update

avast · Sep 6, 2024 · 7665719 · 7665719
1 parent 1bc6d80
commit 7665719
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/epstats/server/req.py b/src/epstats/server/req.py
@@ -171,7 +171,7 @@ def check_trigger(self):
             if not self.goal:
                 raise ValueError("Goal is required for scope 'trigger'")
         else:
-            if not (self.dimension or self.value):
+            if not (self.dimension and self.value):
                 raise ValueError("Dimension and value are required for this scope")
         return self
 

diff --git a/src/epstats/toolkit/experiment.py b/src/epstats/toolkit/experiment.py
@@ -131,7 +131,7 @@ def __post_init__(self):
             if not self.goal:
                 raise ValueError("Trigger scope requires goal")
         else:
-            if not (self.dimension or self.value):
+            if not (self.dimension and self.value):
                 raise ValueError("Dimension and value are required for this scope")