allow pipe character in dimension values (#34)

avast · May 23, 2022 · b3dd42b · b3dd42b
1 parent ffcac58
commit b3dd42b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/setup.cfg b/setup.cfg
@@ -1,6 +1,6 @@
 [metadata]
 name = ep-stats
-version = 1.2.0
+version = 1.2.1
 description = Statistical package to evaluate ab tests in experimentation platform.
 long_description = file: README.md
 long_description_content_type = text/markdown

diff --git a/src/epstats/toolkit/parser.py b/src/epstats/toolkit/parser.py
@@ -27,7 +27,7 @@ def __init__(self, nominator: str, denominator: str):
         goal = Word(alphas + "_" + nums).setParseAction(Goal)
         number = Word(nums).setParseAction(Number)
         dimension = Word(alphas + "_").setParseAction(Dimension)
-        dimension_value = Word(alphanums + "_" + "-" + "." + "%" + " " + "/").setParseAction(DimensionValue)
+        dimension_value = Word(alphanums + "_" + "-" + "." + "%" + " " + "/" + "|").setParseAction(DimensionValue)
         dimension_list = delimitedList(dimension + "=" + dimension_value)
 
         ep_goal = (func + "(" + unit_type + "." + agg_type + "." + goal + ")").setParseAction(EpGoal)

diff --git a/tests/epstats/toolkit/test_parser.py b/tests/epstats/toolkit/test_parser.py
@@ -271,6 +271,16 @@ def test_raise_if_duplicate_dimensions():
                 "test_unit_type.unit.conversion": {"x": "", "y": ""},
             },
         ),
+        (
+            Parser(
+                "count(test_unit_type.global.conversion(x=A/ A|BB, y=X|Y|Z))",
+                "count(test_unit_type.unit.conversion)",
+            ),
+            {
+                "test_unit_type.global.conversion[x=A/ A|BB, y=X|Y|Z]": {"x": "A/ A|BB", "y": "X|Y|Z"},
+                "test_unit_type.unit.conversion": {"x": "", "y": ""},
+            },
+        ),
     ],
 )
 def test_get_goals_dimensional(parser, expected_goals):