Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to build when path to Python contains spaces #441

Closed
falki147 opened this issue Dec 14, 2018 · 1 comment
Closed

Fails to build when path to Python contains spaces #441

falki147 opened this issue Dec 14, 2018 · 1 comment
Assignees
@s3rvac
Labels
bug C-build-system P-build

Comments

@falki147
Copy link

I tried to build the project but it failed when trying to run Python scripts while installing with CMake. The scripts cmake/install-external.cmake and deps/yaracpp/CMakeLists.txt just copy the path to it (PYTHON_EXECUTABLE) without regards for spaces (my Python installation is in the Program Files (x86) folder). This causes the build to fail without any error messages (it just says that it failed)
@s3rvac s3rvac self-assigned this Dec 17, 2018
s3rvac added a commit that referenced this issue Dec 17, 2018
@s3rvac
cmake: Add missing quotes around PYTHON_EXECUTABLE (#441).
dc45b4c 
This fixes installation of RetDec when the path to Python contains spaces (e.g.
when Python is in "Program Files (x86)" on Windows).
@s3rvac
Copy link
Member

s3rvac commented Dec 17, 2018

Thank you for the report! I have added the missing quotes in commit dc45b4c and verified that RetDec is now installable when Python is in a path containing spaces.

@s3rvac s3rvac closed this as completed Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s3rvac s3rvac

Labels
bug C-build-system P-build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s3rvac @falki147