Add support for limiting the overall memory of our unpacker (#290) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can be used to limit the maximal memory to (1) the given number of bytes or (2) half of system RAM.
…-max-memory-half-ram. They are just forwarded to retdec-unpacker. They can be used to limit the maximal memory to (1) the given number of bytes or (2) half of system RAM.
…h from retdec-decompiler.sh. Now that retdec-unpacker.sh supports limiting of memory, we should take advantage of that. Previously, the above parameters were passed only to fileinfo, bin2llvmir, and llvmir2hll.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for limiting the overall memory of our unpacker (see #290).
Regression tests for this feature were added in avast/retdec-regression-tests#7 (merge the present PR before merging the PR with tests).