Computation of section entropies for ELF, MACHO and PE (in progress) #501
Conversation
|
It seems that this branch is based on the branch for #440 (it contains the same commits). Shouldn't it be based on |
|
right, i'll fix that |
| { | ||
| const auto overlaySize = getOverlaySize(); | ||
| const auto declSize = getDeclaredFileLength(); | ||
| const auto bytes = getBytes(); |
There was a problem hiding this comment.
Beware that storing the result of
const std::vector<unsigned char>& getBytes() const;into
const auto bytes = getBytes();causes the vector to be copied, i.e. the type of bytes will be const std::vector<unsigned char>. I believe what you want is
const auto &bytes = getBytes();which will store a reference, i.e. the type of bytes will be const std::vector<unsigned char> &.
| return; | ||
| } | ||
|
|
||
| auto data = reinterpret_cast<const uint8_t *>(bytes.data()); |
There was a problem hiding this comment.
Do we need a reinterpret_cast cast for this? Doesn't a static_cast suffice?
There was a problem hiding this comment.
| @@ -118,6 +119,10 @@ void MachODetector::getSections() | |||
| fsec.setMemoryAlignment(pow(2, mSec->getAlignment())); | |||
| fsec.setRelocationsOffset(mSec->getRelocationOffset()); | |||
| fsec.setNumberOfRelocations(mSec->getNumberOfRelocations()); | |||
| if(sec->getEntropy(entropy)) | |||
There was a problem hiding this comment.
I suggest defining double entropy; right before if(sec->getEntropy(entropy)), not 14 lines before. It is generally a good practice to define variables as close to their first use, especially when they are not initialized.
JakubPruzinec
force-pushed
the
section_entropy
branch
from
ac645c4
to
20a8e7a
Compare
#502
I've implemented extraction of section entropies for various file formats.
Tests are not implemented yet, thus the "in progress" status.