Version info parsing #519
Merged
Version info parsing #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please take a look at the merge conflict here? Thanks. |
metthal
requested changes
Mar 28, 2019
|
|
||
| namespace retdec { | ||
| namespace fileformat { | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove the empty line here
| std::string iconHashSha256; ///< iconhash SHA256 | ||
| std::string iconPerceptualAvgHash; ///< icon perceptual hash AvgHash | ||
| std::vector<std::unique_ptr<Resource>> table; ///< stored resources | ||
| std::vector<ResourceVersion *> resourceVersions; ///< icon groups |
| { | ||
| private: | ||
| // TODO | ||
| size_t iconGroupID; ///< icon group id |
There was a problem hiding this comment.
Should iconGroupID be in ResourceVersion class?
JakubPruzinec
force-pushed
the
version_info
branch
from
6ba5a96
to
fbce869
Compare
metthal
added a commit
that referenced
this pull request
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#408
Added support for: