Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSD (in general) build fixes. #598

Merged
merged 1 commit into from
Jun 26, 2019
Merged

BSD (in general) build fixes. #598

merged 1 commit into from
Jun 26, 2019

Conversation

devnexen
Copy link
Contributor

the dlopen api is part of the libc in OpenBSD and NetBSD.
backtrace api does not belong to the libc in BSD unlike Linux.

@devnexen
BSD (in general) build fixes.
dbc1ef5 
the dlopen api is part of the libc in OpenBSD and NetBSD.
backtrace api does not belong to the libc in BSD unlike Linux.
@s3rvac s3rvac self-requested a review June 26, 2019 07:44
@s3rvac s3rvac self-assigned this Jun 26, 2019
s3rvac
s3rvac approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. We do not use BSD, so we are unable to verify the changes on a BSD system. However, builds on other systems have succeeded, and the changes look alright, so I am going to merge it.

@s3rvac s3rvac merged commit 62db217 into avast:master Jun 26, 2019
s3rvac added a commit that referenced this pull request Jun 27, 2019
@s3rvac
Add a CHANGELOG entry for #598.
0344f29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rvac s3rvac s3rvac approved these changes

Assignees

@s3rvac s3rvac

Labels
bug O-bsd P-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devnexen @s3rvac @krytarowski