Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIPS: Support orphaned lo16 relocs. Fixes #627 #628

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

bmourit
Copy link
Contributor

@bmourit bmourit commented Aug 24, 2019

MIPS: Add support for orphaned lo16 relocations.

This fixes issue #627

MIPS: Add support for orphaned lo16 relocations.

This fixes issue avast#627
@bmourit
Copy link
Contributor Author

bmourit commented Aug 27, 2019

The actual issue here is on line 794:
if (lastMipsHi16 == nullptr) return;

The lo16 could technically still be processed without any hi16 value at all. While this patch does fix the issue, it does so by storing info that is technically unneeded.
In the end, however, this is probably the simplest solution, as any other would likely require even more additional code to handle this 1 specific case.

@PeterMatula
Copy link
Collaborator

Looks ok, lets Run TeamCity builds.

@PeterMatula
Copy link
Collaborator

Well, some regression tests in TeamCity builds failed, but this is due to changes in regression tests suite and RetDec master branch - these repos changed, but changes were not merged to this PR. So this is probably nothing to worry about.

@PeterMatula PeterMatula merged commit 604049a into avast:master Sep 12, 2019
@PeterMatula
Copy link
Collaborator

Manually tested - it is ok.

PeterMatula added a commit that referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants