Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the detection of the Eziriz packer/protector #746

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Improve the detection of the Eziriz packer/protector #746

merged 3 commits into from
Apr 21, 2020

Conversation

ladislav-zezula
Copy link
Contributor

No description provided.

Ladislav Zezula added 2 commits April 20, 2020 15:30
@s3rvac s3rvac changed the title Lz eziriz Improve the detection of the Eziriz packer/protector Apr 20, 2020
s3rvac
s3rvac requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build on Linux&macoOS fails, so I was unable to run the tests. Could you please fix the build (see my remark below)? I will then run all the tests.

src/cpdetect/compiler_detector/compiler_detector.cpp Outdated Show resolved Hide resolved
src/cpdetect/cptypes.cpp Outdated Show resolved Hide resolved
support/yara_patterns/tools/pe/x86/packers.yara Show resolved Hide resolved
@s3rvac
Copy link
Member

s3rvac commented Apr 21, 2020

Thank you for the fixes. Let's run TeamCity tests.

s3rvac
s3rvac approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests pass, code LGTM, so I am approving the PR and merging 🙂

@s3rvac s3rvac merged commit 06793db into master Apr 21, 2020
@s3rvac s3rvac deleted the LZ_Eziriz branch April 21, 2020 04:54
s3rvac added a commit that referenced this pull request Apr 21, 2020
@s3rvac
Add a CHANGELOG entry for #746.
6a08906
@s3rvac s3rvac mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rvac s3rvac s3rvac approved these changes

Assignees

@s3rvac s3rvac

Labels
C-cpdetect enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislav-zezula @s3rvac