Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lz retdec 54 #981

Merged
merged 5 commits into from
Jul 21, 2021
Merged

Lz retdec 54 #981

merged 5 commits into from
Jul 21, 2021

Conversation

ladislav-zezula
Copy link
Contributor

No description provided.

@PeterMatula PeterMatula self-requested a review July 12, 2021 06:37
@PeterMatula
Copy link
Collaborator

Let's run TC tests.

@PeterMatula
Copy link
Collaborator

@ladislav-zezula Code and tests look ok, but features.windrivers.Test regression tests is failing across all the architectures. I hoped it is some small detail, but it looks like after this change, there are major differences in the underlying data. I'm adding outputs before and after the change. There is much less code in the output C after the change. In .dsm files, we can see that before the change, there were much more data that got decoded into instructions. After the change, these bytes are zero and we don't get instruction, functions, etc.
I'm not sure if this is ok - i.e. it was bad before, or if your changes have some bad side effects. Can you please have a look - you know more about it than I do. If you won't know right away, we may investigate it together.
out.zip

@ladislav-zezula
Copy link
Contributor Author

Let's run TC tests.

@PeterMatula PeterMatula merged commit d3677c2 into master Jul 21, 2021
PeterMatula added a commit that referenced this pull request Jul 21, 2021
@ladislav-zezula ladislav-zezula deleted the LZ_RETDEC_54 branch August 3, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants