This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Create 188.json : Added some personal favourite quotes. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some personal favourite quotes.
avats-dev
suggested changes
Sep 26, 2020
There was a problem hiding this comment.
Nice work @swapniljha001 🎉 and thanks for your contribution.
As 188.json have been merged recently, there are merge conflicts now. And as you've opened #13 also, can you merge these both files in 187.json or alternatively you can create a new one 190.json for this one.
Thanks.
Renamed the file as mentioned in #14 (review) in #14.
|
@avats-dev I have changed the filename to |
avats-dev
approved these changes
Sep 30, 2020
|
Thanks, @avats-dev for accepting the PR 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check one of the below boxes as per your PR
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@avats-devfor help, in a comment belowThanks!