Skip to content

Commit

Permalink
Remove sharers/gp (#151)
Browse files Browse the repository at this point in the history
* feat: remove sharers/gp

* test: remove VanillaSharing.gp, add VanillaSharing.getTwUrl
  • Loading branch information
avdeev authored Nov 22, 2019
1 parent 44fa234 commit 715ba01
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 55 deletions.
10 changes: 0 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,16 +162,6 @@ tumblr({
})
```

### `gp(options)`

Share on Google+

```js
gp({
url: string,
})
```

### `vk(options)`

Share on vk.com
Expand Down
7 changes: 0 additions & 7 deletions demo/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ <h1><a href="https://alexey-avdeev.com/vanilla-sharing/">vanilla-sharing</a> dem
<button id="reddit" type="button">Share on Reddit</button>
<button id="pinterest" type="button">Share on Pinterest</button>
<button id="tumblr" type="button">Share on Tumblr</button>
<button id="gp" type="button">Share on Google</button>
<button id="vk" type="button">Share on VK</button>
<button id="ok" type="button">Share on Odnoklassniki</button>
<button id="mail" type="button">Share on Mail.ru</button>
Expand Down Expand Up @@ -120,12 +119,6 @@ <h1><a href="https://alexey-avdeev.com/vanilla-sharing/">vanilla-sharing</a> dem
});
});

document.getElementById('gp').addEventListener('click', function() {
VanillaSharing.gp({
url: META.URL,
});
});

document.getElementById('vk').addEventListener('click', function() {
VanillaSharing.vk({
url: META.URL,
Expand Down
2 changes: 0 additions & 2 deletions src/main.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { fbFeed, getFbFeedUrl } from './sharers/fbFeed';
import { fbShare, getFbShareUrl } from './sharers/fbShare';
import { fbButton, getFbButtonUrl } from './sharers/fbButton';
import gp from './sharers/gp';
import mail from './sharers/mail';
import { email, getEmailUrl } from './sharers/email';
import { ok, getOkUrl } from './sharers/ok';
Expand All @@ -27,7 +26,6 @@ export {
reddit,
pinterest,
tumblr,
gp,
vk, getVkUrl,
ok, getOkUrl,
mail,
Expand Down
10 changes: 0 additions & 10 deletions src/sharers/gp.js

This file was deleted.

23 changes: 0 additions & 23 deletions src/sharers/tests/gp.test.js

This file was deleted.

3 changes: 1 addition & 2 deletions typing-tests/vanilla-sharing-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,11 @@ url = VanillaSharing.getFbButtonUrl();
window = VanillaSharing.messenger();

window = VanillaSharing.tw();
window = VanillaSharing.tw();
url = VanillaSharing.getTwUrl();

window = VanillaSharing.reddit();
window = VanillaSharing.pinterest();
window = VanillaSharing.tumblr();
window = VanillaSharing.gp();

window = VanillaSharing.vk();
url = VanillaSharing.getVkUrl();
Expand Down
1 change: 0 additions & 1 deletion vanilla-sharing.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export function getTwUrl(...args: any[]): string;
export function reddit(...args: any[]): any;
export function pinterest(...args: any[]): any;
export function tumblr(...args: any[]): any;
export function gp(...args: any[]): any;

export function vk(...args: any[]): any;
export function getVkUrl(...args: any[]): string;
Expand Down

0 comments on commit 715ba01

Please sign in to comment.