Pinterest and tumblr #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 21, 2018 12:05
…er sharing. Also, updated package.json and demo index.html file
avdeev
requested changes
Jun 21, 2018
README.md
Outdated
| ### `tumblr(options)` | ||
|
|
||
| Share on Tumblr | ||
|
|
There was a problem hiding this comment.
attach a link to the documentation, please
There was a problem hiding this comment.
attached link to documentation of both in this push
README.md
Outdated
| ### `pinterest(options)` | ||
|
|
||
| Share on Pinterest | ||
|
|
There was a problem hiding this comment.
attach a link to the documentation, please
package.json
Outdated
| @@ -16,7 +16,7 @@ | |||
| "main": "dist/vanilla-sharing.umd.js", | |||
| "module": "dist/vanilla-sharing.esm.js", | |||
| "scripts": { | |||
| "precommit": "lint-staged", | |||
| "precommit": "npm run lint --", | |||
There was a problem hiding this comment.
At first, when i was trying to make my first commit on windows machine, npm was showing an error with change as suggested fix. The issue persisted on two different windows machine at home and work. So, I changed it. Now, I am unable to reproduce the error. So, reverted to lint-staged.
avdeev
approved these changes
Jun 21, 2018
|
@prateekrastogi Thanks! I released it. |
|
@avdeev Thanks. Just added the dependency in my project 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pinterest and tumblr.
Also, added hashtag field in twitter, and title field in reddit.