Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email body not displaying in Outlook 2010 #32

Merged
merged 3 commits into from
Jul 2, 2018

Conversation

stphnnnn
Copy link
Contributor

I've removed the empty subject parameter from the email sharer which was causing the subject of the created email to be "&body=" in some email clients (Outlook 2010) and for the actual body not to be displayed.

I've tested in a number of other email clients to ensure that this doesn't cause any unwanted side effects but I'm not sure if this was deliberate and I'm missing something 🙃

What do you think?

This causes the email body to not display in Outlook 2010
@avdeev
Copy link
Owner

avdeev commented Jun 27, 2018

@stphnnnn I dont know. But i can bump the major version :)

I think we can do a little research.

@avdeev
Copy link
Owner

avdeev commented Jun 28, 2018

@stphnnnn MDN agrees with you. :)subject is not required param.

Can you change unit tests?

@coveralls
Copy link

coveralls commented Jun 30, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 73efb55 on stphnnnn:fix-email-empty-subject into 772cf32 on avdeev:master.

@stphnnnn
Copy link
Contributor Author

Brilliant! Tests updated :)

@avdeev avdeev merged commit 57a6a21 into avdeev:master Jul 2, 2018
@avdeev
Copy link
Owner

avdeev commented Jul 2, 2018

@stphnnnn Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants