Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a maintained fork of go-bindata #1680

Closed
wants to merge 1 commit into from
Closed

add a maintained fork of go-bindata #1680

wants to merge 1 commit into from

Conversation

komuw
Copy link

@komuw komuw commented Nov 11, 2017

There was a PR that was merged a few days ago #1675 that removed go-bindata and rightly so.

I would like to propose that we add https://github.com/shuLhan/go-bindata which is a maintained fork of go-bindata.

My reasons are:

  1. https://github.com/shuLhan/go-bindata is maintained. The last release was only 4 days ago[1]
  2. The maintainer is active on the project. As a proxy to that, he has merged no less than 10 pull requests in the last 3months[2]
  3. The maintainer has offered to review and merge all open PR's from the parent bindata repo to his fork[3]
  4. Because go-bindata is awesome

ref:

  1. https://github.com/shuLhan/go-bindata/releases/tag/v3.2.0
  2. https://github.com/shuLhan/go-bindata/pulls?q=is%3Apr+is%3Aclosed
  3. https://github.com/jteeuwen/go-bindata/issues/165#issuecomment-328291324

(PR template omitted; doesn't seem to be applicable.)

Copy link
Collaborator

@cassiobotaro cassiobotaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfornately we have golint issues
image
and also a low coverage
image

@cassiobotaro
Copy link
Collaborator

We wait 8 days for your interaction, PR will be closed. See more in CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants