Allow closing short-break window #21 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @baradgur I made some patch and fixes, and now it is merged to master. |
|
thanks for the fixes! |
avestura
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Allow closing short-break window with right click
about: Close short brake popup with right click
Description
Added an option to close the Short-break window with a right click
PR Domain
Which change are you proposing?
Issue relation
[This PR is related to issue #21 ]
Screenshots
'No Screenshots'
Additional context
I am avare that the closing the Short-break window does not stop the short-break timer, but I'm not sure how (and whether) I should implement it. If you have any suggestion please guide me.
This is my first commit to a open source project - any critique would be welcome. Thanks!