Drop request
and request-promise
deps
#19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See elm-lang/elm-platform#231 for motivation! This would drop about 4MB off every installer that uses it, which in turn would make them install faster. 🚀
This originally replaced
request
andrequest-promise
withrequest-stream
, which is more lightweight than either. It's a tiny wrapper around Node's built-inhttp
andhttps
modules which adds support for passing in URLs (Node's core lib requires separately specifying hostname, port, protocol, etc) and for following redirects, and that's about it.Then I took it a step further and removed
request-stream
in favor of directly using the built-inhttp
andhttps
modules. This has the downside of not following redirects, but it's not much work (or much code) to re-add support for that if it seems important. (I defaulted to assuming it's not, based on howbinwrap
is used in practice.)Here are the dependencies post-PR:
I recommend viewing this PR with
?w=1
.