Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with locally-installed Elm 0.18 #12

Closed
ghost opened this issue Nov 15, 2016 · 7 comments
Closed

Doesn't work with locally-installed Elm 0.18 #12

ghost opened this issue Nov 15, 2016 · 7 comments
Assignees

Comments

@ghost
Copy link

ghost commented Nov 15, 2016

elm-upgrade gave me ERROR: Elm 0.18 required, but found Elm Platform 0.17.1.
I'd installed 0.18 locally as per this advice for using Elm in production.

@avh4
Copy link
Owner

avh4 commented Nov 15, 2016

What do you get when running elm directly from the commandline? And what do you get for which elm ?

@eeue56
Copy link
Collaborator

eeue56 commented Nov 15, 2016

@avh4, we should look for node_modules in the folder and default to using that version of elm if found. I'll make a PR in a minute

@eeue56 eeue56 self-assigned this Nov 15, 2016
@ghost
Copy link
Author

ghost commented Nov 15, 2016

@avh4
elm gives me Elm Platform 0.17.1 - a way to run all Elm tools.
node_modules/.bin/elm give me Elm Platform 0.18.0 - a way to run all Elm tools.
which elm gives me /usr/local/bin/elm.
which node_modules/.bin/elm gives me node_modules/.bin/elm.

@avh4
Copy link
Owner

avh4 commented Nov 15, 2016

ah, I see. (I hadn't understood what "locally-installed") meant

@avh4
Copy link
Owner

avh4 commented Nov 15, 2016

(@eeue56, FYI I'll be publishing a new elm-upgrade release tonight after releasing elm-format-0.5.2)

@avh4
Copy link
Owner

avh4 commented Nov 16, 2016

Fixed in #16. Will be in 0.18.5 release (to be published in a few minutes)

@avh4 avh4 closed this as completed Nov 16, 2016
@ghost
Copy link
Author

ghost commented Nov 16, 2016

Ah, yes, I should have said installed in node_modules/.bin, not locally-installed!

avh4 added a commit that referenced this issue Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants