Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should it be an error instead of a warning when a dependency doesn't support the target Elm version? #3

Closed
avh4 opened this issue Nov 11, 2016 · 3 comments

Comments

@avh4
Copy link
Owner

avh4 commented Nov 11, 2016

For example, a project upgrade shows:

WARNING: rtfeldman/elm-validate has not been upgraded to 0.18 yet!

But then also indicates success at the end. Should this instead be a fatal error for the upgrade?

cc @eeue56

@eeue56
Copy link
Collaborator

eeue56 commented Nov 11, 2016

It should definitely not be a fatal error - but maybe it should log it as an error.

The reasoning being, if you can upgrade 90% of the deps, that's great. Then you want to handle the package that isn't upgraded yet somehow. Maybe we can add a link so they can make a PR or something.

@avh4
Copy link
Owner Author

avh4 commented Nov 11, 2016

Maybe slightly change the message to something like "The author of rtfeldman/elm-validate hasn't yet published a version that's compatible with Elm 0.18" to sort of hint at what needs to be done

@avh4
Copy link
Owner Author

avh4 commented Nov 12, 2016

Closed via #5

@avh4 avh4 closed this as completed Nov 12, 2016
avh4 added a commit that referenced this issue Apr 19, 2018
avh4 added a commit that referenced this issue Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants