Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap quality & fps labels, darken dark theme #94

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Conversation

PickleNik
Copy link
Contributor

  • darkened background to match new YouTube's redesign background color.
  • swap label highlights to what's more important for the slider value (slider changes the quality so the xxxp number should be more visible)
  • put support links into a dropdown to save up some vertical space.
  • readme updated with dark mode screenshot.

Screenshot 2023-04-23 at 1 18 31 AM

@PickleNik
Copy link
Contributor Author

Screenshot 2023-04-23 at 1 23 00 AM

pnpm seems to have updated the lockfile

@avi12
Copy link
Owner

avi12 commented Apr 23, 2023

Thanks for the PR!
I quite like this color scheme and the quality label's new position
The "Support developer" collapsible is an interesting change

@PickleNik
Copy link
Contributor Author

Thanks for the PR! I quite like this color scheme and the quality label's new position The "Support developer" collapsible is an interesting change

Feel free to undo whatever you'd like! :) I just made some changes for myself and decided to make a PR if you want them

@avi12
Copy link
Owner

avi12 commented Apr 23, 2023

Tomorrow I will merge the PR and work on an update
The downside of changing the UI is that I need to produce new screenshots for every fully-translated language

@avi12
Copy link
Owner

avi12 commented Apr 23, 2023

Side note, I pinged you on Twitter

Repository owner deleted a comment from nikita-voc Apr 23, 2023
@avi12 avi12 merged commit 42fc40f into avi12:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants