[Checkout.com] Implementation of all functions with test cases #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes #1: Introducing `Response.t` with docs * [monei] Adapted for new `Response.t` * Refactored `commit`, `respond` for readability * [monei] Updated test cases * Corrected specs * [bogus] Adapted for Response.t
* Gringotts does not start any process now * Removed `adapter` key from config as it was redundant. * Updated docs and mix task.
- Updated dependency `xml_builder`. The new `generate/2` provides a
`format: :none | :indented` option.
- `:format` is set to `:none` to produce "minified" network requests.
* This is almost a complete rewrite to reduce code duplication.
- check_response_type() was acting as guard that matched only against
some response types. It did not handle the scenario when a non-supported
response would be obtained. It really served no purpose
- check_response_type -> extract_gateway_response
+ This guards as well as fetches, previously the fetch was being
done multiple times.
* Moved all response handling inside the `ResponseHandler`.
* Since we now have a struct, and want to deprecate `:success`, `Response.success/1` and `Response.error/1`, helpers now act on structs.
* `errorCode` and `errorText` are used to build `:reason`.
+ Removed pointless asserts from tests.
Also added CAVV result filed to the response which is nil for MaasterCards (as per ANet docs).
* Fix Adapter moduledoc and bogus gateway * Fixes #24 * bogus test also uses Money protocol now * Changed validate_config docs * Improved mix task docs (filename) * Better module name suggestion * Now, Filename can be specified on the CLI with the `-f` flag * Added changelog and contributing guide. * Also reworded README slightly * Correct "amount" in examples to ex_money * Replaced example bindings with links to `.iex.exs` * Removed unused params from functions. * Fix call to `downcase`
* Ignore some optional params for RF, RV, CP Some optional params like billing, customer, merchant must not be expanded in case of capture, refund and void. * Improved mock tests, fixes #98 Mock tests now mostly check if the request is correctly built. Since most requests have common parameters, they are not checked everywhere. * Improve integration tests (more cases), fixes #108 * Integration tests no longer use the worker as a workaround for #8 * Added more test cases, can possibly be improved using describe blocks with local setup. * There are almost no assertions and it is expected that errors will bubble up to the pattern matches.
* Trexle does not seem to provide fraud risk, AVS, CVV validation results. There are no docs for this.
* Refactored ResponseHandler, updated Response.t * CAMS now parses AVS and CVV response - that was missing till now. * Removes unnecessary `parse` clause. * Mock tests shouldn't use gringotts.ex
* Update travis config, add .formater.exs * Migrate to CodeCov * Travis will run the formatter check * Add git-hooks and update contribution guide * Changed credo lin-length config from 80 to 100 * Ran the formatter on the project * Fix credo warnings
[global-collect] Layout, docs and code refactor =============================================== New features ------------ Risk, AVS, CVS fields added in `Response` struct! Layout, docs ----------- * `credo` issues resolved. * Corrected `amount` in examples * Ran the elixir 1.6 code formatter - Used sigils in mocks Code refactors -------------- * Removed unnecessary functions - Reduced arity of `add_money` * Refactored Timex usage * Removed a test on `validate_config` as it is already tested.
* Bumped version to 1.1.0 * Not running integration tests on travis * Added Changelog for release 1.1.0(refer CHANGELOG.md)
* New public methods: refund * `store` has been removed because Paymill does not have a direct API integration for card token generation * Improved docs and uses Money protocol Refactors ---------- * refactored add_amount -> amount_params * updated tests and clubbed a few parse clauses * refactored commit and response functions Tests ------ * Paymill mock (#159) * Added mock test cases for paymill. * Configured mock files to get compiled in `:test` env. * Moved paymill responses in mocks folder.
This reverts commit ce714be.
Codecov Report
@@ Coverage Diff @@
## dev #167 +/- ##
==========================================
- Coverage 77.33% 70.34% -6.99%
==========================================
Files 14 15 +1
Lines 375 489 +114
==========================================
+ Hits 290 344 +54
- Misses 85 145 +60
Continue to review full report at Codecov.
|
oyeb
force-pushed
the
dev
branch
2 times, most recently
from
e8323fd
to
73ea35e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of :
Authorize/3Capture/3Purchase/3void/2refund/3and its supportive private functions