Remove wirecard and update upstream, ex_money #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #170 +/- ##
===========================================
+ Coverage 66.82% 77.33% +10.51%
===========================================
Files 14 14
Lines 434 375 -59
===========================================
Hits 290 290
+ Misses 144 85 -59
Continue to review full report at Codecov.
|
* Remove implementation of protocol for ex_money, monetized - ex_money 2.6.0 implements it for us. - Remove ex_money from deps and tests Added a `Gringotts.FakeMoney` a struct that implements the protocol in the test env. This struct is meant to be used only in tests. * Update upstream deps * Update the changelog for 1.1.1-rc * Update travis config (elixir 1.6.3 -> 1.6.5) Closes #54, #104 and #106 as we remove wire_card. Closes #169
oyeb
added a commit
that referenced
this pull request
Jun 6, 2018
* Remove wire_card and fix docs (#170) * Remove implementation of protocol for ex_money, monetized - ex_money 2.6.0 implements it for us. - Remove ex_money from deps and tests Added a `Gringotts.FakeMoney` a struct that implements the protocol in the test env. This struct is meant to be used only in tests. * Update upstream deps * Update the changelog for 1.1.1-rc * Update travis config (elixir 1.6.3 -> 1.6.5) Closes #54, #104 and #106 as we remove wire_card. Closes #169
oyeb
added a commit
that referenced
this pull request
Jun 6, 2018
* Remove wire_card and fix docs (#170) * Remove implementation of protocol for ex_money, monetized - ex_money 2.6.0 implements it for us. - Remove ex_money from deps and tests Added a `Gringotts.FakeMoney` a struct that implements the protocol in the test env. This struct is meant to be used only in tests. * Update upstream deps * Update the changelog for 1.1.1-rc * Update travis config (elixir 1.6.3 -> 1.6.5) Closes #54, #104 and #106 as we remove wire_card. Closes #169
oyeb
added a commit
that referenced
this pull request
Jun 8, 2018
* Remove wire_card and fix docs (#170) * Remove implementation of protocol for ex_money, monetized - ex_money 2.6.0 implements it for us. - Remove ex_money from deps and tests Added a `Gringotts.FakeMoney` a struct that implements the protocol in the test env. This struct is meant to be used only in tests. * Update upstream deps * Update the changelog for 1.1.1-rc * Update travis config (elixir 1.6.3 -> 1.6.5) Closes #54, #104 and #106 as we remove wire_card. Closes #169
vikramjadon921995
pushed a commit
to vikramjadon921995/gringotts
that referenced
this pull request
Jun 28, 2018
* Remove wire_card and fix docs (aviabird#170) * Remove implementation of protocol for ex_money, monetized - ex_money 2.6.0 implements it for us. - Remove ex_money from deps and tests Added a `Gringotts.FakeMoney` a struct that implements the protocol in the test env. This struct is meant to be used only in tests. * Update upstream deps * Update the changelog for 1.1.1-rc * Update travis config (elixir 1.6.3 -> 1.6.5) Closes aviabird#54, aviabird#104 and aviabird#106 as we remove wire_card. Closes aviabird#169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major step towards
v1.1.1🎉See the milestone for more.
Money protocol
ExMoneynow implements theGringotts.Moneyprotocol so we don't need to implement it for them (Test ex_money support of Gringotts.Money protocol #169).ex_moneyin our deps!FakeMoneystruct that is available intestenv. Since it implements the protocol as well, it is useful in tests (all tests have been updated because of this).Misc
Updated upstream dependencies, changed credo settings.
Travis now builds on Elixir versions: 1.5.3 and 1.6.5
Cleanups
Wirecardmodule was in no shape to be used and does not meet the standard for this library and is hence removed. Given that it was unusable, there is no need to provide any deprecation period.