Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JET error invalid lookup expr with new public keyword #636

Closed
gdalle opened this issue Jun 5, 2024 · 7 comments · Fixed by #637
Closed

JET error invalid lookup expr with new public keyword #636

gdalle opened this issue Jun 5, 2024 · 7 comments · Fixed by #637

Comments

@gdalle
Copy link

gdalle commented Jun 5, 2024

JET.test_package throws an error on Julia 1.11 with perfectly valid uses of the new public keyword:

invalid lookup expr public mysymbol

MWE: https://github.com/gdalle/JETPublicTest.jl (check out the CI log)

See also:

@gdalle gdalle changed the title Invalid lookup with new public keyword JET error invalid lookup expr with new public keyword Jun 5, 2024
@gdalle
Copy link
Author

gdalle commented Jun 8, 2024

@aviatesk I added a very minimal MWE to the issue if you want to take a look

@aviatesk
Copy link
Owner

aviatesk commented Jun 8, 2024

Thanks, JET's toplevel analysis feature currently lacks a support for the keyword. It should be feasible to implememt that though.

@gdalle
Copy link
Author

gdalle commented Jun 8, 2024

It would be amazing, thank you!
I use JET.test_package in all my packages and recommend it in ModernJuliaWorkflows, but this single keyword makes all my tests fail on 1.11 and above.

@gdalle
Copy link
Author

gdalle commented Jun 8, 2024

In the meantime, is it possible to deactivate / ignore it somehow?

@aviatesk
Copy link
Owner

aviatesk commented Jun 8, 2024

No, but I'll try to implement it this weekend.

@gdalle
Copy link
Author

gdalle commented Jun 8, 2024

Very cool, thanks. I can't overstate how useful JET is to me, so if you need a beta-tester let me know.

aviatesk added a commit that referenced this issue Jun 13, 2024
aviatesk added a commit that referenced this issue Jun 13, 2024
aviatesk added a commit that referenced this issue Jun 13, 2024
@gdalle
Copy link
Author

gdalle commented Jun 13, 2024

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants