-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minimum adjustments to JuliaLang/julia#52233 #612
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
- Coverage 89.50% 89.44% -0.06%
==========================================
Files 10 10
Lines 3000 3002 +2
==========================================
Hits 2685 2685
- Misses 315 317 +2 ☔ View full report in Codecov by Sentry. |
This lacks invalidation support (since this commit still uses the external code cache), but this lets JET to run on the latest nightly at least.
75dbaf3
to
09905ef
Compare
JET Benchmark ResultJudge resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
JET Benchmark ResultJudge resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
|
@@ -150,6 +150,10 @@ end | |||
# global | |||
# ------ | |||
|
|||
@static if VERSION ≥ v"1.11.0-DEV.1552" | |||
CC.cache_owner(analyzer::AbstractAnalyzer) = AnalysisCache(analyzer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still not sure if AnalysisCache
is the right object here. What needs to be captured is information that changes inference behaviour. See https://github.com/JuliaGPU/GPUCompiler.jl/blob/8d7d9836447c067973a2c90aa4b274a09e7b2b20/src/interface.jl#L223 as an alternative idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, AnalysisCache(analyzer)
is unique, kind of like how GPUCompilerCacheToken
is. The reason is each analyzer computes unique hash based on analysis settings, creating different AnalysisCache
objects for different settings:
JET.jl/src/analyzers/jetanalyzer.jl
Line 77 in 56520e0
analysis_cache = get!(AnalysisCache, JET_ANALYZER_CACHE, cache_key) |
This lacks invalidation support (since this commit still uses the external code cache), but this lets JET to run on the latest nightly at least.