Fix ground truth Tf changing parent frame #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emiliano Borghi <emiliano.borghi@gmail.com>
|
Thanks for this fix. This may have been causing us some headaches behind the scenes as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you work with AMCL or any other localization algorithm and relocalize the robot, a jump in the robot frame occurs, more precisely in the TF between map and odometry:
Map <--> Odom <--> Robot.The current setup in
masterpublishes ground truth withOdomas parent frame and, because of this, when the jump happens, ground truth also changes, which is unexpected.This PR allows developers to modify the parent frame of ground truth to a static TF that is not affected by localization.
Signed-off-by: Emiliano Borghi emiliano.borghi@gmail.com