Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump manylinux to recent version. #9

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Bump manylinux to recent version. #9

merged 2 commits into from
Jul 19, 2023

Conversation

Hooksie
Copy link
Collaborator

@Hooksie Hooksie commented Jul 19, 2023

Switch github action and release build to manylinux_2_28. manylinux_2_24 is EOL as of Jan 1. The last build for 0.3.0 did not get released due to a pipeline error.

Swaps the repo commands for Almalinux compatible ones, since the upstream base image has changed distro. I've also removed the explicit lib and include env vars for openssl-sys. The discovery method seems to work appropriately.

Tested by running the release wheel in a clean python:3.11.4-bullseye container.

Bumping the patch release as well to avoid conflicts on release. I've also included an update to the test actions, to pre-test specifically for manylinux to catch build errors in the future.

Signed-off-by: Matt Hooks <mhooks@rippling.com>
Signed-off-by: Matt Hooks <mhooks@rippling.com>
Copy link
Owner

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aviramha aviramha merged commit a0cc863 into master Jul 19, 2023
@aviramha aviramha deleted the bump-manylinux branch July 19, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants