feat!: rename CANCELLED/UPDATED to SKIPPED/IN_PROGRESS #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed CANCELLED to SKIPPED and UPDATED to IN_PROGRESS in the ScheduledClusterUpgradeStatus type to align with the new API. This reflects the current states of cluster upgrades. Jira ticket: AME-3318
idebeijer
approved these changes
Oct 1, 2024
djmarkoz
deleted the
AME-3318-rename-cancel-upgrade-to-skip-version-to-better-cover-the-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed CANCELLED to SKIPPED and UPDATED to IN_PROGRESS in the ScheduledClusterUpgradeStatus type to align with the new API. This reflects the current states of cluster upgrades.
BREAKING CHANGES:
This modifies the ScheduledClusterUpgradeStatus constants, which may break existing implementations relying on CANCELLED or UPDATED.
Jira ticket: AME-3318