Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update structurizr libraries #179

Merged
merged 7 commits into from
Mar 16, 2023
Merged

Conversation

jp7677
Copy link
Contributor

@jp7677 jp7677 commented Mar 15, 2023

And also introduce our own section title extraction since this property has been removed.

@jp7677
Copy link
Contributor Author

jp7677 commented Mar 15, 2023

This PR also resolves #163 by including the updated libraries.

jp7677 added 2 commits March 16, 2023 08:48
To avoid confusion with the still existing title property.
@dirkgroot dirkgroot merged commit de8ad51 into avisi-cloud:main Mar 16, 2023
@qtzar
Copy link
Contributor

qtzar commented Mar 16, 2023

Looking forward to this as it also introduces nested groups.

I've been trying to figure out how the sidebar list of software systems is generated so that I can show the groupings in an accordian style. I got the updated libraries working in my own fork but also noticed the missing section titles but hadn't tried fixing them yet

@dirkgroot
Copy link
Collaborator

Looking forward to this as it also introduces nested groups.

I've been trying to figure out how the sidebar list of software systems is generated so that I can show the groupings in an accordian style. I got the updated libraries working in my own fork but also noticed the missing section titles but hadn't tried fixing them yet

The code for generating the sidebar menu is in MenuViewModel.kt and Menu.kt.

@simonbrowndotje
Copy link

Looking forward to this as it also introduces nested groups.

Just FYI, structurizr-export:1.12.1 has a number of problems with nested groups. I think they're all resolved, but I'd like to do more testing before releasing structurizr-export:1.13.0 -> https://github.com/structurizr/export/blob/main/docs/changelog.md

@qtzar
Copy link
Contributor

qtzar commented Mar 17, 2023

@simonbrowndotje Out of curiosity, do you see any benefit around being able to build a diagram based on a group?

Lets say, for example, I have a nested group like company/portfolio/prodteam that contains a number of softwareSystems it would be interesting to see a diagram based on that prodteam group so the team can quickly see all their systems and the systems they have relationships with.

@simonbrowndotje
Copy link

Out of curiosity, do you see any benefit around being able to build a diagram based on a group?

I do, yes. This isn't documented, but groups can be given identifiers, and used in element expressions:

workspace {

    model {
        properties {
            structurizr.groupSeparator /
        }
        
        group "company" {
            group "portfolio" {
                prodteam1 = group "prodteam1"
                    a = softwareSystem "A"
                }
                prodteam2 = group "prodteam2"
                    b = softwareSystem "B"
                }
                prodteam3 = group "prodteam3"
                    c = softwareSystem "C"
                }
                prodteam4 = group "prodteam4"
                    d = softwareSystem "D"
                }
            }
        }
        
        a -> b
        b -> c
        c -> d
    }

    views {
        systemLandscape {
            include ->prodteam2->
            autoLayout lr
        }
    }
    
}

image

@qtzar
Copy link
Contributor

qtzar commented Mar 29, 2023

@dirkgroot Any chance a new release can be made to get this PR with nested groups and section titles support available sooner?

@dirkgroot
Copy link
Collaborator

@qtzar Sure! I've created version 1.0.26.

@jp7677 jp7677 deleted the section-title branch April 6, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles appear in the legend of the example site, but not locally
4 participants