Container and Component links on diagrams. #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xist. Added links from the Container View to the Component view if Components exist. If multiple component views exist then it links to an anchor link to scroll to the correct position.
dirkgroot
requested changes
Mar 29, 2023
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/model/DiagramViewModel.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/views/SoftwareSystemComponentPage.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/C4PlantUmlExporterWithElementLinks.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/C4PlantUmlExporterWithElementLinks.kt
Outdated
Show resolved
Hide resolved
|
I've removed the anchor links on the components page and implemented your suggested changes for the logic involved with adding the links. This is my first time writing in Kotlin so I'm learning as I go. I've also added a couple of new tests for the container and component links. |
jp7677
suggested changes
Apr 5, 2023
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/C4PlantUmlExporterWithElementLinks.kt
Outdated
Show resolved
Hide resolved
dirkgroot
approved these changes
Apr 5, 2023
jp7677
approved these changes
Apr 5, 2023
|
@qtzar Thanks a lot for the contribution, this is a nice addition. Again sorry for the slow responses from our side! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds links to containers and components in the context and container views.
closes #164