Add pan and zoom for diagrams #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce modal dialog for diagrams with pan and zoom options. Also move export links to that dialog. Co-authored-by: Declan Lynch <declan.lynch@dcsg.com>
|
@jp7677 Just pulled the PR locally and tested it out. It looks good to me. Hopefully there can be a release done soon, lots of great new features waiting in the main branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce modal dialog for diagrams with pan and zoom options.
Also move export links to that dialog.
Supersedes #309
@qtzar While testing your branch I've modified quite a lot of code, so creating a new PR was kind-of easier. Could you please confirm that this PR works for you? I've also removed the config option. The dialog is a cool thing, no need to hide it behind a feature flag.
PS: I've added you as co-author to the commit since the initial work was all yours.