Identify external software systems by custom tag #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Structurizr only enforces this property with nested groups, but not with groups on the first level only.
We have `SoftwareSystem.includedSoftwareSystem` for that.
In other words, validate groups only on the first level, without setting 'structurizr.groupSeparator' property. Also split other test and fix some formatting issues.
Only use 'Model.includedSoftwareSystems' to determine if we include a software system. A side effect is unfortunately that we extended our PageViewModel.
Consider a software system external when groups are used and a software system is outside of any group.
The enterprise boundary is deprecated. Also add other properties for convenience. Due to earlier work, this does not change the presentation of that model in the generated site.
Those settings mostly match the styling in the project. We don't enforce those rules, they are just for convenience for setups with a coresponding IDE plugin.
jp7677
changed the title
|
So with this PR we say good bye (but still support) to the now deprecated enterprise boundary. |
jp7677
commented
Oct 30, 2023
src/main/kotlin/nl/avisi/structurizr/site/generatr/StructurizrUtilities.kt
Outdated
Show resolved
Hide resolved
jp7677
changed the title
jp7677
changed the title
jp7677
force-pushed
the
group-separator
branch
2 times, most recently
from
cca7ec2 to
9047323
Compare
Replace our own heuristics based on groups. Therefore add a property "generatr.site.excludedTag" to define the name of the tag that identifies external systems. Also adjust example.
jp7677
force-pushed
the
group-separator
branch
from
9047323 to
9d29ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There no concept anymore of external/internal locations when not using the now deprecated enterprise boundary.
Do we still want to exclude software systems somehow like we do now with systems outside the enterprise?