Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency bulma to v1 #464

Closed
wants to merge 2 commits into from
Closed

Update dependency bulma to v1 #464

wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 21, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
bulma (source) 0.9.4 -> 1.0.0 age adoption passing confidence

Release Notes

jgthms/bulma (bulma)

v1.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/bulma-1.x branch from f9f66d5 to ecb8d0d Compare March 27, 2024 08:37
@jp7677
Copy link
Contributor

jp7677 commented Mar 27, 2024

This PR breaks the styling, thus it needs more attention.

@dirkgroot
Copy link
Collaborator

dirkgroot commented Apr 5, 2024

@jp7677 I've committed two small fixes which, as far as I can see, makes it so all colors are again as expected. Could you have a look?

Copy link
Contributor Author

renovate bot commented Apr 5, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@jp7677
Copy link
Contributor

jp7677 commented Apr 8, 2024

@jp7677 I've committed two small fixes which, as far as I can see, makes it so all colors are again as expected. Could you have a look?

Thanks. we are close, but not yet there. I'm seeing that the color of links, like headlines, are still a bit off. What I'm also seeing is that tables, like decision records or dependencies, are no longer scaled to full width.

PS: I would love to have a dark mode ;)

@jp7677
Copy link
Contributor

jp7677 commented May 23, 2024

superseded by #508

@jp7677 jp7677 closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants