Fix for exception on windows #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirkgroot May be a good idea to rebase this branch on top of main to have #484 included. |
dirkgroot
force-pushed
the
fix-exception-on-windows
branch
from
9a5247c to
73efc25
Compare
Good idea, will do. |
dirkgroot
force-pushed
the
fix-exception-on-windows
branch
from
73efc25 to
da19fb8
Compare
jp7677
approved these changes
Apr 11, 2024
|
May be reword the commit message since it seems to actually work :) |
dirkgroot
changed the title
`Path.of` uses OS-specific directory separators to generate a complete path. This causes the problem reported in #463. This commit changes this to use the `File` constructor instead of `Path.of`.
dirkgroot
force-pushed
the
fix-exception-on-windows
branch
from
da19fb8 to
81a14bc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463