Lower the JRE version requirement to version 17 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't use any modern JRE features for this tool, there's no need for it to always require the newest JRE to be installed. Therefore it seems like a good idea to lower the requirement to the lowest JRE version that is required by the libraries this tool uses. This happens to be version 17.
jp7677
reviewed
Apr 10, 2024
jp7677
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't use any modern JRE features for this tool, there's no need for it to always require the newest JRE to be installed. Therefore it seems like a good idea to lower the requirement to the lowest JRE version that is required by the libraries this tool uses. This happens to be version 17.
I made sure this works, by locally creating a distribution and running it using Java 17.