-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container and component tabs on code view #507
Merged
jp7677
merged 4 commits into
avisi-cloud:main
from
LunarN0va:feature/container-component-tabs-on-code-view
May 16, 2024
Merged
Add container and component tabs on code view #507
jp7677
merged 4 commits into
avisi-cloud:main
from
LunarN0va:feature/container-component-tabs-on-code-view
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarN0va
force-pushed
the
feature/container-component-tabs-on-code-view
branch
3 times, most recently
from
May 13, 2024 12:18
a49cd33
to
2f902f7
Compare
jp7677
suggested changes
May 13, 2024
src/main/kotlin/nl/avisi/structurizr/site/generatr/StructurizrUtilities.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/SiteGenerator.kt
Show resolved
Hide resolved
...main/kotlin/nl/avisi/structurizr/site/generatr/site/model/ContainersComponentTabViewModel.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/model/LinkViewModel.kt
Outdated
Show resolved
Hide resolved
...si/structurizr/site/generatr/site/model/SoftwareSystemContainerComponentCodePageViewModel.kt
Outdated
Show resolved
Hide resolved
jp7677
reviewed
May 14, 2024
jp7677
reviewed
May 14, 2024
...test/kotlin/nl/avisi/structurizr/site/generatr/site/model/SoftwareSystemPageViewModelTest.kt
Show resolved
Hide resolved
LunarN0va
force-pushed
the
feature/container-component-tabs-on-code-view
branch
from
May 16, 2024 08:35
2f902f7
to
e888f41
Compare
jp7677
suggested changes
May 16, 2024
src/main/kotlin/nl/avisi/structurizr/site/generatr/StructurizrUtilities.kt
Outdated
Show resolved
Hide resolved
LunarN0va
force-pushed
the
feature/container-component-tabs-on-code-view
branch
from
May 16, 2024 11:21
6a3e139
to
82df49e
Compare
jp7677
approved these changes
May 16, 2024
LunarN0va
force-pushed
the
feature/container-component-tabs-on-code-view
branch
from
May 16, 2024 11:28
82df49e
to
65a10fc
Compare
LunarN0va
force-pushed
the
feature/container-component-tabs-on-code-view
branch
from
May 16, 2024 13:24
65a10fc
to
82b55d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will give the user the option to cycle through all the containers and components that have code views. This will decrease clutter on the code page when too many images get added.