MBS-8041 Refresh expired OpenID token #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-krivobokov
requested review from
dsvoronin,
int02h,
sboishtyan and
fat-fellow
| require(getNamespace() == namespace) { | ||
| "kubernetes.context.namespace should be $namespace. " + | ||
| "Namespace hardcoded in plugin, and this check only prevents from using wrong context" | ||
| } | ||
| requestConfig.oauthTokenProvider = oauthTokenProvider(configFile) | ||
| } |
There was a problem hiding this comment.
| @@ -20,6 +20,7 @@ sealed class KubernetesCredentials : Serializable { | |||
| ) : KubernetesCredentials(), Serializable | |||
| } | |||
|
|
|||
| // TODO: get rid of this default. autoConfig is enabled by default | |||
There was a problem hiding this comment.
This refactoring is out of scope
sboishtyan
approved these changes
Apr 4, 2020
dsvoronin
approved these changes
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support Open Id tokens in k8s for authentication and authorization.
kubectlrefreshes tokens automatically and stores changes to kube config file.Kubernetes - OpenID Connect Tokens
How they look in the config:
id-tokenis the Open id token in Jwt format:{ "iss":"https://xxx", "sub":"xxx", "aud":"k8s", "exp":1585929826, <--- "iat":000, "at_hash":"xxx", "email":"user@mail",exp- is the expiration date. This is how the client knows it in advance.Unfortunately, fabric8 kubernetes-client doesn't refresh tokens.
I've reused implementation from the official client (kubernetes-client/java#871)
Known issues: