Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Document Sorting #235

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

amponce
Copy link
Contributor

@amponce amponce commented Jun 21, 2024

Summary

Fixes the document sorting issue and adds related test cases.

Bug

  • Related issues linked using [fixes #231](https://github.com/avitorio/outstatic/issues/231)
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

New Behavior

icons.mp4

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added

Copy link

changeset-bot bot commented Jun 21, 2024

⚠️ No Changeset found

Latest commit: 3ae456e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 21, 2024

@amponce is attempting to deploy a commit to the Andre Vitorio's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
outstatic-advanced-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 1:19am
outstatic-dev-blog ❌ Failed (Inspect) Jun 25, 2024 1:19am
outstatic-docs ❌ Failed (Inspect) Jun 25, 2024 1:19am

@avitorio
Copy link
Owner

@amponce Great job! Thank you so much for this improvement. Merging it now!

@avitorio avitorio merged commit 20993ce into avitorio:canary Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants