Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing data #1446

Closed
mahalakshme opened this issue Dec 12, 2023 · 2 comments
Closed

Missing data #1446

mahalakshme opened this issue Dec 12, 2023 · 2 comments
Assignees
@1t5j0y

Comments

@mahalakshme
Copy link

mahalakshme commented Dec 12, 2023 •
edited
Loading

https://avni.freshdesk.com/a/tickets/3323 - looks similar to avniproject/avni-client#1214 but the rootcause could be different here.
@mahalakshme mahalakshme converted this from a draft issue Dec 12, 2023
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Dec 12, 2023
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Dec 13, 2023
@1t5j0y 1t5j0y self-assigned this Dec 13, 2023
@vinayvenu vinayvenu moved this from In Progress to Code Review Ready in Avni Product Dec 13, 2023
@vinayvenu vinayvenu moved this from Code Review Ready to In Progress in Avni Product Dec 13, 2023
@1t5j0y
Copy link

1t5j0y commented Dec 13, 2023 •
edited
Loading

  • 1168/6566 records have missing household number.
  • All records with last_modified after November 22 ~5pm IST are affected including newly inserted ones. All these records only have values for "myCHI Id" concept (non mandatory). Few have the values for some other non mandatory fields too ("Other medical history"/"Individual Inactive") .
  • Before November 22, 4 records with last_modified as November 9, 2018 are affected.
  • Bulk of the affected records have last modified between Nov 27-30. Prior to Nov 27 there is barely 1 record per day. These days have 200-300. After Nov 30, there are about 30-40 every day.

1t5j0y added a commit to avniproject/avni-server that referenced this issue Dec 14, 2023
@1t5j0y
avniproject/avni-product#1446 | Allow concept search by parent org as…
c1289d7 
… well
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Dec 14, 2023
@mahalakshme mahalakshme mentioned this issue Dec 14, 2023
Closed
1t5j0y added a commit to avniproject/avni-server that referenced this issue Dec 14, 2023
@1t5j0y
avniproject/avni-product#1446 | Handle parent org concept search by n…
c395d05 
…ame. Throw nullpointer if concept not found while saving observation.
@mahalakshme mahalakshme mentioned this issue Dec 14, 2023
Closed
@1t5j0y
Copy link

1t5j0y commented Dec 14, 2023

Root cause: Server was not checking for concepts in parent org while saving observations which was leading to the observations being discarded before save in DB. Introduced in 5.1.2 in the fix for avniproject/avni-server#648

Code reviewed over chat.
QAd over screenshare.

@1t5j0y 1t5j0y closed this as completed Dec 14, 2023
@github-project-automation github-project-automation bot moved this from Code Review Ready to Done in Avni Product Dec 14, 2023
This was referenced Dec 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1t5j0y 1t5j0y

Labels
None yet
Projects
Avni Product
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahalakshme @1t5j0y