Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable recording for Exotel masked calls #661

Closed
mahalakshme opened this issue Nov 24, 2023 · 6 comments
Closed

Enable recording for Exotel masked calls #661

mahalakshme opened this issue Nov 24, 2023 · 6 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Nov 24, 2023

Ticket: https://avni.freshdesk.com/a/tickets/3264

AC:

Since the Exotel API has changed without backward compatibility being provided(v1 version of API call we are using has changed) in callMasking method set the Record parameter to true.

To test:

Test using Exotel credentials available in Keeweb.

Reference:

https://developer.exotel.com/api/make-a-call-api#call-customer

@mahalakshme mahalakshme converted this from a draft issue Nov 24, 2023
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Nov 24, 2023
@ashusvnath ashusvnath self-assigned this Nov 24, 2023
@ashusvnath ashusvnath moved this from Ready to In Progress in Avni Product Nov 24, 2023
@ashusvnath
Copy link

@mahalakshme : Should "Record" be set to true for all calls or will it be part of request parameter ?

@ashusvnath ashusvnath moved this from In Progress to Code Review Ready in Avni Product Nov 24, 2023
@vinayvenu
Copy link
Member

@mahalakshme This is temporarily ok to go. We need a followup where we make this value configurable in the exotel configuration.

@vinayvenu vinayvenu moved this from Code Review Ready to In Code Review in Avni Product Nov 24, 2023
@vinayvenu vinayvenu moved this from In Code Review to QA Ready in Avni Product Nov 24, 2023
@vinayvenu vinayvenu moved this from QA Ready to In Code Review in Avni Product Nov 24, 2023
@vinayvenu vinayvenu moved this from In Code Review to Code Review with Comments in Avni Product Nov 27, 2023
@ashusvnath
Copy link

@vinayvenu : I verified that the Record parameter accepts the sting 'true' by manually invoking API using postman.

@ashusvnath ashusvnath moved this from Code Review with Comments to QA Ready in Avni Product Nov 27, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 28, 2023
@mahalakshme
Copy link
Contributor Author

@ashusvnath commit needs to be also put in 5.1 branch for 5.1.3 release

@ashusvnath
Copy link

@mahalakshme Done

@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Nov 29, 2023
@himeshr
Copy link
Contributor

himeshr commented Nov 29, 2023

Using Exotel GET Bulk CallDetails APIs, we verified that the recordingUrl is available for the calls made with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants