Managing direct assignments of individual to user

[mahalakshme]

https://avni.freshdesk.com/a/tickets/3263

Current scenario:

Currently individual unable to assign to a user (avniproject/avni-client#1058). They are assigned via group assignment. But we should be able to assign individuals also to user.

Premise:

Individual assignment to users should be possible independent of group assignment to the users, since the group that the individual belongs to might change or identified at a later point of time.

Acceptance criteria:

• Able to assign individual to a user
• When a assigned individual to a user, is added to group not assigned to a user, group should not be synced and individual should be synced
• When a group is assigned to a user, like now assign all individuals in the group to the user - already done but make sure to retain the behaviour
• When a new member added to a group assigned to a user, the member should be assigned to the user - already done but make sure to retain the behaviour
• When a group is unassigned from the user, individuals in the group should continue to remain assigned to the user
• When a individual is tried to unassign from a user, but group in which individual belongs to is assigned to the user, user should not be able to do this and get a error message that states 'individualName{say Arun} cant be unassigned from the userName{say Rahul}, since group, groupName{say Class12} that individualName{say Arun} belongs to, is assigned to the userName{say Rahul}.
• On bulk unassignment, when some of the individuals has above issue, do not save any of them. Collate the errors and display.

Corner Test cases:

• Say a individual is assigned to a user, and then a group that individual belongs to is assigned to the user - should work without failing
• On bulk assign of individuals to a list of users(where some have the individual already assigned) - should work

[himeshr]

Code changes done so far:

• Individual assignment to users should be possible independent of group assignment to the users, since the group that the individual belongs to might change or identified at a later point of time.
• Able to assign individual of group as well as non-group subject-type to a user directly
• When a assigned individual to a user, is added to group not assigned to a user, group should not be synced and individual should be synced
• When a group is assigned to a user, like now assign all individuals in the group to the user - already done but make sure to retain the behaviour
• When a new member added to a group assigned to a user, the member should be assigned to the user - already done but make sure to retain the behaviour
• When a group is unassigned from the user, individuals in the group should continue to remain assigned to the user
• When a individual is tried to unassign from a user, but group in which individual belongs to is assigned to the user, user should not be able to do this and get a error message that states 'individualName{say Arun} cant be unassigned from the userName{say Rahul}, since group, groupName{say Class12} that individualName{say Arun} belongs to, is assigned to the userName{say Rahul}.
• On bulk unassignment, when some of the individuals has above issue, do not save any of them. Collate the errors and display.

Corner Test cases:

• Say a individual is assigned to a user, and then a group that individual belongs to is assigned to the user - should work without failing
• On bulk assign of individuals to a list of users(where some have the individual already assigned) - should work
• Say a group is assigned to an User, where atleast one of the member is not within the User's catchment, the group and member's within the User's catchment should get synced to the User without any failures(Association errors).

[himeshr]

Dev testing screen recordings are attached here-in:

PartialSuccessOfBulkUnassignment.mov

ErrorWhileRemovingMemberWhenGroupIsStillAssigned.mov

[mahalakshme]

@petmongrels are you reviewing this?

[himeshr]

When a non-group individual is assigned to a user, but its group is not assigned to the same user, we will get error in client during sync, as it would not find the related Group entity.
As a fix, throw an exception of type IgnorableSyncError and handle the same during persist to ingore only those specific entities.

[himeshr]

• we throw error Individual (%s) cant be unassigned from the user (%s), since group (%s) that the member (%s) belongs to, is assigned to the user (%s)

@mahalakshme and @vinayvenu
This is also supported in the current version of code. Resolved the doubt on call with Vivek.
Moving to QA Ready.

[himeshr]

@petmongrels Have done this additional commit, because, for the case where Household is within the User's catchment but a Member isn't we would have ended up with a sync error, as we do not (and cannot) check for GroupSubjectMapping -Member being within catchment during syncable items determination on server.

Related test-case:
Say a group is assigned to an User, where atleast one of the member is not within the User's catchment, the group and member's within the User's catchment should get synced to the User without any failures(Association errors).

[AchalaBelokar]

• Created a student which is not part of any group and assign and unassigned to the user. it is working properly
• Then created a student which is part of one group and then I assigned that group to user and try to unassigned that user it through the error
• Able to assign individual of group as well as non-group subject-type to a user directly
• When a assigned individual to a user, is added to group not assigned to a user, group should not be synced and individual should be synced
• When a group is unassigned from the user, individuals in the group should continue to remain assigned to the user

[AchalaBelokar]

• I am trying to assign single student to the user it is showing me this error.

Screen.Recording.2023-12-18.at.4.47.21.PM.mov

@himeshr can you look at this

[himeshr]

• I am trying to assign single student to the user it is showing me this error.

Screen.Recording.2023-12-18.at.4.47.21.PM.mov
@himeshr can you look at this

I have added debounce to avoid invoking the backend api repeatedly when user keeps clicking on a username.
Should work fine once the webapp fix is deployed.

[Dinesh2019]

1.Taking time to select the assigned to user
2.If we select the user in the assigned to and select the check box under name it is getting refreshed the assign to or remove the user from the assign to

Screen.Recording.2023-12-19.at.11.56.01.AM.mov

[himeshr]

1.Taking time to select the assigned to user 2.If we select the user in the assigned to and select the check box under name it is getting refreshed the assign to or remove the user from the assign to

Screen.Recording.2023-12-19.at.11.56.01.AM.mov

@Dinesh2019 Create a separate bug, the Individual is correctly assigned / unassigned from the user the first time around.
Its just that on clicking the checkbox, it gets reset to initial state.

[Dinesh2019]

@himeshr created the bug card avniproject/avni-webapp#1106

[himeshr]

@AchalaBelokar, we've made an additional commit related to this card. To update the last modified date time for all UserSubjectAssignment and GroupSubject entities.

Therefore, please perform another round of testing for LAHI org DirectSubjectAssignment to User feature,

1. for catchments where there is missing Students for a KarigarBatch
2. for multiple users with different catchments
3. with old and new prerelease apks

[AchalaBelokar]

• Assign individual to user
• Assign group individual to user which contain user
• Assign group which is not part of catchment
• Assign individual which is not a part of user catchment
• Add individual to the group where the individual and group are already assign to that user
• add individual to the group where the individual and group are already assign to that user then remove the user from group and sync
• When a assigned individual to a user, is added to group not assigned to a user, group should not be synced and individual should be synced
• When a group is unassigned from the user, individuals in the group should continue to remain assigned to the user
• When a individual is tried to unassign from a user, but group in which individual belongs to is assigned to the user, user should not be able to do this and get a error message
• bulk unassignment
• Say a individual is assigned to a user, and then a group that individual belongs to is assigned to the user
• On bulk assign of individuals to a list of users(where some have the individual already assigned) - should work