Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject type not available in /api/subjects #712

Closed
Tracked by #1574 ...
vinayvenu opened this issue Apr 10, 2024 · 3 comments
Closed
Tracked by #1574 ...

Subject type not available in /api/subjects #712

vinayvenu opened this issue Apr 10, 2024 · 3 comments
Assignees

Comments

@vinayvenu
Copy link
Member

The value of "Subject type" is available only when it is requested in the url, and not present when it is not requested in the url.

eg:

Request https://app.rwb.avniproject.org/api/subjects?subjectType=Farmer
Response

{
    "content": [
        {
            "Subject type": "Farmer",
            "ID": "a6caa3d2-3d95-45c7-b439-15dc0a59467e",
...

Request https://app.rwb.avniproject.org/api/subjects
Response

{
    "content": [
        {
            ~~"Subject type": "Farmer",~~
            "ID": "a6caa3d2-3d95-45c7-b439-15dc0a59467e",
...
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Apr 10, 2024
@vinayvenu vinayvenu moved this from New Issues to Code Review Ready in Avni Product Apr 11, 2024
@vinayvenu vinayvenu self-assigned this Apr 12, 2024
@himeshr himeshr moved this from Code Review Ready to QA Ready in Avni Product Apr 15, 2024
@himeshr himeshr moved this from QA Ready to Code Review with Comments in Avni Product Apr 15, 2024
@himeshr
Copy link
Contributor

himeshr commented Apr 15, 2024

This change could cause issues for other External API consumers, as they might rely on the field to determine the subjectType amongst the returned entities, when invoking GET ALL Subjects.

If a change is to be done, i would recommend retaining the subjectType Name details always irrespective of "subjectType=" filter being specified.

@1t5j0y 1t5j0y moved this from Code Review with Comments to QA Ready in Avni Product Apr 15, 2024
@1t5j0y 1t5j0y moved this from QA Ready to Code Review with Comments in Avni Product Apr 15, 2024
@vinayvenu
Copy link
Member Author

vinayvenu commented Apr 15, 2024

@himeshr this was a recent break in functionality. I doubt if any existing consumers will be affected by it.

@himeshr himeshr moved this from Code Review with Comments to QA Ready in Avni Product Apr 15, 2024
@vinayvenu
Copy link
Member Author

Relevant commit fb31d5c

1t5j0y pushed a commit that referenced this issue Apr 15, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Apr 17, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Apr 18, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Apr 19, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants