Add Dockerfile and update workflow for Avni Server Dockerization #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsluthra
reviewed
Nov 9, 2023
| @@ -0,0 +1,3 @@ | |||
| FROM amazoncorretto:8 | |||
There was a problem hiding this comment.
Does Avni server need JDK v8? Seems quite old.
There was a problem hiding this comment.
Yes Gurpreet, Currently Avni Server runs on Java 8
mohan-13
reviewed
Nov 9, 2023
| <<: *tags_filter | ||
| requires: | ||
| - test | ||
| - build_docker_image: |
There was a problem hiding this comment.
@yenugukeerthana Since the secrets are added under context, Please add the context entry here. Ref: https://circleci.com/docs/contexts/
There was a problem hiding this comment.
Done @mohan-13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Dockerfile to the project, providing instructions for building a Docker image of the Avni Server. Additionally, the workflow configuration has been updated to facilitate the Dockerization process.