Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to identify the location of the form input in concepts page #1116

Closed
Tracked by #1557 ...
mahalakshme opened this issue Jan 15, 2024 · 7 comments
Closed
Tracked by #1557 ...
Assignees
Labels
good first issue Good for newcomers

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jan 15, 2024

Someone need to fix the comments and merge the PR since the contributor will not be any more available.

Issue:

While navigating to Home->App Designer->Concepts->{Specific Concept}, there is a section called "Used in forms". When the form size is huge, it is hard to figure out the exact location of the element in the form. Also, the form designer currently does not support exact locations.

Hence, it will be useful to display the form name and question name as well. Question name also is needed, since concept names might not be always same as question names.

Acceptance criteria

  • On the concept screen, the page name and question name needs to be shown along with the form name. Refer the screenshot below to understand how to display the same.
Screenshot 2024-03-29 at 1 12 28 PM
  • Hand cursor should not be shown on page name and question name
  • For a form element within an another form element which has a Question group concept type, show 4 levels ie. Form name -> Section name -> Question name of question group -> Question name of the form element

Tech details

  • Currently, /web/concept/usage/{conceptUuid} provides the form element group uuid, but not the name. Change GET /web/concept/usage/{conceptUuid} in avni-server accordingly to achieve the above
  • Ensure that navigation stays unaffected
@mahalakshme mahalakshme converted this from a draft issue Jan 15, 2024
@vinayvenu vinayvenu added the good first issue Good for newcomers label Feb 29, 2024
@mahalakshme mahalakshme moved this from In Analysis to Analysis Complete in Avni Product Mar 20, 2024
@mahalakshme mahalakshme changed the title In the concept page also display form element group used in along with form Add ability to identify the location of the forn input Mar 29, 2024
@mahalakshme mahalakshme changed the title Add ability to identify the location of the forn input Add ability to identify the location of the form input Mar 29, 2024
@mahalakshme mahalakshme changed the title Add ability to identify the location of the form input Add ability to identify the location of the form input in concepts page Mar 29, 2024
@mahalakshme mahalakshme moved this from Analysis Complete to In Analysis Review in Avni Product Mar 29, 2024
@d1vyanshu-kumar
Copy link

Working on this issue.

d1vyanshu-kumar added a commit to d1vyanshu-kumar/avni-webapp that referenced this issue Jun 25, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Code Review Ready in Avni Product Jun 25, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Jun 28, 2024
@petmongrels
Copy link
Contributor

This implementation will not perform due to n+1 remote calls problem, i.e. n is number of usage of forms for a concept. For example if a concept is used in 3 forms, it would lead to 3 calls to server from web app to get the form details. Secondly each call is getting full form to the browser to find out where the form element is used.

This should be implemented by fixing the /web/concept/usage/{uuid} endpoint on avni-server.

@petmongrels petmongrels moved this from In Code Review to Code Review with Comments in Avni Product Jun 28, 2024
@mahalakshme
Copy link
Contributor Author

@d1vyanshu-kumar kindly note the above comment, which needs to be fixed.

@d1vyanshu-kumar
Copy link

d1vyanshu-kumar commented Jul 4, 2024

@mahalakshme please review this i already made changes in the Avni server:
avniproject/avni-server#739

@mahalakshme mahalakshme moved this from Code Review with Comments to Code Review Ready in Avni Product Jul 4, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Jul 5, 2024
@petmongrels petmongrels moved this from In Code Review to Code Review Ready in Avni Product Jul 5, 2024
@petmongrels
Copy link
Contributor

@d1vyanshu-kumar pls share the commit for web app changes

@petmongrels petmongrels moved this from Code Review Ready to Code Review with Comments in Avni Product Jul 25, 2024
@mahalakshme
Copy link
Contributor Author

@d1vyanshu-kumar can you pls share the commit

@mahalakshme mahalakshme moved this from Code Review with Comments to Ready in Avni Product Sep 17, 2024
1t5j0y added a commit to avniproject/avni-server that referenced this issue Nov 1, 2024
@1t5j0y 1t5j0y self-assigned this Nov 1, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Nov 14, 2024
@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Nov 14, 2024
@dinesh2096 dinesh2096 self-assigned this Nov 14, 2024
@dinesh2096 dinesh2096 moved this from QA Ready to In QA in Avni Product Nov 14, 2024
@dinesh2096
Copy link

dinesh2096 commented Nov 14, 2024

  • Can we add the format for Used in form as well so that user knows which form group and question used in the form element.

QA Reference :

Image

@dinesh2096 dinesh2096 moved this from In QA to QA Failed in Avni Product Nov 14, 2024
1t5j0y added a commit that referenced this issue Nov 20, 2024
@1t5j0y 1t5j0y moved this from In Progress to QA Ready in Avni Product Nov 20, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 21, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

6 participants